1

Closed

Empty string evaluation seems broken in 4.2 Beta 2

description

I think I've found a problem with empty string evaluation in C1 4.2 Beta 2

In the menu bar I find that pages that have empty content in "Menu Title" still generate output.
There is generated ul / li tag and a link to the page, but without text.
The same problem applies to Toplink function of the sitemap page.

I have done the following steps to provoke the situation.
  1. Installed 4.1 via WebMatrix
  2. Selected default in all parameters
  3. Check the sitemap link was present at the far right.
  4. Installed 4.2 Beta 2
  5. Found that sitemap text was now gone, but the link was still being created.
Closed Apr 23 at 12:19 PM by wysocki
Fixed in the latest build

comments

wysocki wrote Apr 22 at 9:57 AM

Thank you for reproting this issue. It's been registered in our HQ TFS as Issue # 4693.

This is not an issue with the Menu Title, it's related to changes in handling CultureName in data types in v. 4.2.

NOTE: It concerns old-version starter sites like Open Cph and Tiny Cph. Venus works OK.

Repro:
  1. Install the latest 4.2 build.
  2. Select a starter site (e.g. Open Cph Starter Site - Razor)
  3. When initialized, check the front page for the Sitemap link in the top right corner.
Expected: The sitemap link is there
Actual: No Sitemap link
  1. In the Content perspective, expand Websites / Open Cph Starter Site / Top links
  2. Try to edit the Sitemap item.
Expected: The item opens OK
Actual: "Error executing action"
  1. Check the log
Expected: No errors
Actual: see below

--- LOG ---

2014-04-22 12:27:56.98
Composite.Data.DynamicTypes.ParseDefinitionFileException: /App_Data/Composite/DynamicTypeForms/Layout/Navigation/TopLink.xml(5:18): Invalid binding name 'CultureName'
at Composite.Data.DynamicTypes.DataTypeDescriptorFormsHelper.GenerateForm()
...
2014-04-22 12:27:56.96
Composite.Data.DynamicTypes.ParseDefinitionFileException: /App_Data/Composite/DynamicTypeForms/Layout/Navigation/TopLink.xml(5:18): Invalid binding name 'CultureName'
at Composite.Data.DynamicTypes.DataTypeDescriptorFormsHelper.GenerateForm()
...

napernik wrote Apr 23 at 11:50 AM

Thank you for reporting the issue. Will be fixed in the next commit.

Workaround for the second problem (not being able to edit the link) - editing /App_Data/Composite/DynamicTypeForms/Layout/Navigation/TopLink.xml and removing the line where the CultureName" binding is defined.